iter conservation efforts: save the endangered .iter() and .into_iter() #3119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also needs to be updated in |
joshtriplett
force-pushed
the
a-message-from-the-save-the-iters-foundation
branch
from
a5d296a to
8f30cb2
Compare
|
@flip1995 Done, thanks. |
|
More serious supporting information: many crates turn this off, including crates like cargo, and clap. |
|
Oh and the tests/ui/update-references.sh 'target/debug/test_build_base' 'for_loop.rs' |
Make explicit_iter_loop and explicit_into_iter_loop allow-by-default, so that people can turn them on if they want to enforce that style; avoid presenting them as *the* idiomatic Rust style, rather than just *a* style.
joshtriplett
force-pushed
the
a-message-from-the-save-the-iters-foundation
branch
from
8f30cb2 to
7799883
Compare
|
@flip1995 Done. |
|
(The appveyor failure looks spurious.) |
|
Thanks! Appveyor error is unrelated: #3118 |
|
@joshtriplett could you leave the requested comment on #3230 ? This is a minor PR so it doesn't really count, but might as well get the sign off if I can 😄 |
|
On October 2, 2018 4:44:13 AM PDT, Manish Goregaokar ***@***.***> wrote:
@joshtriplett could you leave the requested comment on #3230 ? This is
a minor PR so it doesn't really count, but might as well get the sign
off if I can 😄
Done.
|
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every day, more iters are lost, discarded as unwanted, to such hazards
as "concision" and "brevity". Won't someone think of the poor .iter()
and .into_iter(), that future generations may continue to admire them
and their self-documenting properties in their many and varied natural
habitats, and not merely in a zoo of (en)closures?
Make explicit_iter_loop and explicit_into_iter_loop allow-by-default, so
that people can turn them on if they want to enforce that style; avoid
presenting them as the idiomatic Rust style, rather than just a style.